nik/lush
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

GC may get stuck during a parser and avoids proper resizing of the

Browse Source 
string table, making its lists grow too much and degrading performance.
This commit is contained in:
Roberto Ierusalimschy
2009-11-23 12:59:30 -02:00
parent 062e809e54
commit 9a6d9ea57a
1 changed files with 27 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
bugs
View File

@@ -1880,8 +1880,8 @@ patch = [[
+++ lundump.c 2008/04/04 19:51:41 2.7.1.4 +++ lundump.c 2008/04/04 19:51:41 2.7.1.4
@@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
/* /*
-** $Id: bugs,v 1.103 2009/08/04 18:51:19 roberto Exp roberto $ -** $Id: bugs,v 1.104 2009/08/05 13:09:38 roberto Exp roberto $
+** $Id: bugs,v 1.103 2009/08/04 18:51:19 roberto Exp roberto $ +** $Id: bugs,v 1.104 2009/08/05 13:09:38 roberto Exp roberto $
** load precompiled Lua chunks ** load precompiled Lua chunks
** See Copyright Notice in lua.h ** See Copyright Notice in lua.h
*/ */
@@ -2232,3 +2232,28 @@ patch = [[
]], ]],
} }
Bug{
what = [[GC may get stuck during a parser and avoids proper resizing of
the string table,
making its lists grow too much and degrading performance]],
report = [[Sean Conner, 2009/11/10]],
since = [[5.1]],
example = [[See http://lua-users.org/lists/lua-l/2009-11/msg00463.html]],
patch = [[
--- llex.c 2007/12/27 13:02:25 2.20.1.1
+++ llex.c 2009/11/23 14:49:40
@@ -118,8 +118,10 @@
lua_State *L = ls->L;
TString *ts = luaS_newlstr(L, str, l);
TValue *o = luaH_setstr(L, ls->fs->h, ts); /* entry for `str' */
- if (ttisnil(o))
+ if (ttisnil(o)) {
setbvalue(o, 1); /* make sure `str' will not be collected */
+ luaC_checkGC(L);
+ }
return ts;
}
]]
}